[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 11AT_KEYWORDS-without-commas.diff
From: |
Akim Demaille |
Subject: |
Re: 11AT_KEYWORDS-without-commas.diff |
Date: |
Tue, 29 Apr 2003 12:17:41 +0200 |
User-agent: |
Gnus/5.090018 (Oort Gnus v0.18) Emacs/21.3 (gnu/linux) |
| This is a fix for a bug in AT_KEYWORDS that was preventing a second
| call from working. The problem was that the comma being used as a
| field seperator ended up wreaking havoc somewhere in m4_append_uniq
| on the second call to AT_KEYWORDS.
|
| I decided not to try and mess with the quoting in m4_append_uniq and
| m4_append. I just changed the field seperator AT_KEYWORDS passes to those
| functions to a space instead.
OK. We should keep this in mind though.
| The AT_KEYWORDS change below addresses the above. The second part maybe
| should have been a second patch, but it allows multiple invocations of
| --keywords= to a testsuite and restricts keyword matches to whole keywords
| unless maybe if the user passes a regexp to --keywords=.
|
| Index: ChangeLog
| 2003-04-01 Derek Price <address@hidden>
|
| * lib/autotest/general.m4 (AT_KEYWORDS): Don't use a comma as the
| seperator with m4_append_uniq(). It doesn't work.
| (AT_CLEANUP): Add `;' to end of at_help_all.
| (AT_INIT): Allow --keyword to be specified more than once. When
| grepping $at_help_all for keywords, use the field and keyword
| seperators to ensure a complete keyword match.
Please, install.