Re: Fixes for autom4te "make -j" hack

[Paul Eggert]

Eric Sunshine <address@hidden> writes:

> +## We need to
> +## recognize all cases, so we check simply for "j" in MAKEFLAGS, since that
> +## seems to be the lowest common denominator.

But that could find instances of 'j' in MAKEFLAGS that have nothing
to do with jobs.  How about this more-conservative patch instead?

2003-10-06  Paul Eggert  <address@hidden>

        * lib/Autom4te/XFile.pm: Don't assume -j is solo.
        Issue a more-informative diagnostic.
        Problems reported by Eric Sunshine.

--- XFile.pm.~1.10.~    Tue Sep 30 12:33:29 2003
+++ XFile.pm    Mon Oct  6 00:28:00 2003
@@ -225,10 +225,11 @@ sub lock
   # However, if the invoker is using "make -j", the problem is not harmless,
   # so report it in that case.  Admittedly this is a bit of a hack.
   if (!flock ($fh, $mode)
-      && (!$!{ENOLCK} || " $ENV{'MAKEFLAGS'}" =~ / (-j|--jobs)/))
+      && (!$!{ENOLCK}
+         || " -$ENV{'MAKEFLAGS'}" =~ / (-[BdeikrRsSw]*j|---?jobs)/))
     {
       my $file = $fh->name;
-      fatal "cannot lock $file with mode $mode: $!";
+      fatal "cannot lock $file with mode $mode (perhaps you are running make 
-j on a lame NFS client?): $!";
     }
 }