autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Documentation for new FC Fortran macros


From: Akim Demaille
Subject: Re: Documentation for new FC Fortran macros
Date: Wed, 08 Oct 2003 10:51:04 +0200
User-agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux)

 > Attached is a revised patch for autoconf.texi without the @node mangling.

Great, please install when you want.



 > address@hidden Fortran 77 Compiler
 > address@hidden Fortran 77 Compiler Characteristics
 > address@hidden Fortran Compiler
 > address@hidden Fortran Compiler Characteristics
 > +
 > +The autoconf Fortran support is divided into two categories: legacy

autoconf is an executable.  You mean the package, hence _A_utoconf.


 > address@hidden AC_PROG_F77_C_O/AC_PROG_FC_C_O

Please, use @defmacx instead.

But anyway, this macro is an error, it has no application AFAIK.
Historically even AC_PROG_CC_C_O was very dubious, and was tailored
for GNU Make (that's why not only does it check $CC, but cc too).  I
fail to see the need to propagate it.  Who uses it anyway?


 > address@hidden AC_F77_LIBRARY_LDFLAGS
 > address@hidden AC_F77_LIBRARY_LDFLAGS/AC_FC_LIBRARY_LDFLAGS

Definitely @defmacx for the second.


 > address@hidden AC_F77_MAIN
 > address@hidden AC_F77_MAIN/AC_FC_MAIN

Likewise (stopping to repeat from here, but there are other occurrences).




 > +By default, the FC macros perform their tests using a @file{.f}

If you mean to use FC like this in the text body, it ought to be
@code{FC} then.  Several occurrences.



 > -To check for a syntax feature of the (C, C++, or Fortran 77) compiler,
 > +To check for a syntax feature of the (C, C++, Fortran, or Fortran 77) 
 > compiler,

Do we really need to keep F77?  Or actually, do we need to keep this
language list at all?  I would remove it.

 >  such as whether it recognizes a certain keyword, or simply to try some
 >  library feature, use @code{AC_COMPILE_IFELSE} to try to compile a small
 >  program that uses that feature.
 > @@ -6350,7 +6492,7 @@
 >  This macro uses @code{CFLAGS} or @code{CXXFLAGS} if either C or C++ is
 >  the currently selected language, as well as @code{CPPFLAGS}, when
 >  compiling.  If Fortran 77 is the currently selected language then
 > address@hidden will be used when compiling.
 > address@hidden will be used when compiling, or @code{FCFLAGS} for Fortran.

Likewise, I would go to a more robust

      This macro uses the appropriate compilation flags for the
      current language (@pxref{The place where these guys are
      defined}).
 
 >  It is customary to report unexpected failures with
 >  @code{AC_MSG_FAILURE}.  This macro does not try to link; use
 > @@ -6390,7 +6532,7 @@
 >  This macro uses @code{CFLAGS} or @code{CXXFLAGS} if either C or C++ is
 >  the currently selected language, as well as @code{CPPFLAGS}, when
 >  compiling.  If Fortran 77 is the currently selected language then
 > address@hidden will be used when compiling.
 > address@hidden will be used when compiling, or @code{FCFLAGS} for Fortran.

Gee...  Cut!

 
 >  It is customary to report unexpected failures with
 >  @code{AC_MSG_FAILURE}.  This macro does not try to execute the program;
 > @@ -13475,11 +13617,11 @@
 
 >  For C and C++, @var{includes} is any @code{#include} statements needed
 >  by the code in @var{function-body} (@var{includes} will be ignored if
 > -the currently selected language is Fortran 77).  This macro also uses
 > address@hidden or @code{CXXFLAGS} if either C or C++ is the currently
 > -selected language, as well as @code{CPPFLAGS}, when compiling.  If
 > -Fortran 77 is the currently selected language then @code{FFLAGS} will be
 > -used when compiling.
 > +the currently selected language is Fortran or Fortran 77).  This macro
 > +also uses @code{CFLAGS} or @code{CXXFLAGS} if either C or C++ is the
 > +currently selected language, as well as @code{CPPFLAGS}, when compiling.
 > +If Fortran 77 is the currently selected language then @code{FFLAGS} will
 > +be used when compiling, or @code{FCFLAGS} for Fortran.
 >  @end defmac

Cut!
 
 >  @defmac AC_TRY_CPP (@var{input}, @ovar{action-if-true}, 
 > @ovar{action-if-false})
 > @@ -13509,12 +13651,12 @@
 
 >  For C and C++, @var{includes} is any @code{#include} statements needed
 >  by the code in @var{function-body} (@var{includes} will be ignored if
 > -the currently selected language is Fortran 77).  This macro also uses
 > address@hidden or @code{CXXFLAGS} if either C or C++ is the currently
 > -selected language, as well as @code{CPPFLAGS}, when compiling.  If
 > -Fortran 77 is the currently selected language then @code{FFLAGS} will be
 > -used when compiling.  However, both @code{LDFLAGS} and @code{LIBS} will
 > -be used during linking in all cases.
 > +the currently selected language is Fortran or Fortran 77).  This macro
 > +also uses @code{CFLAGS} or @code{CXXFLAGS} if either C or C++ is the
 > +currently selected language, as well as @code{CPPFLAGS}, when compiling.
 > +If Fortran 77 is the currently selected language then @code{FFLAGS} will
 > +be used when compiling, or @code{FCFLAGS} for Fortran.  However, both
 > address@hidden and @code{LIBS} will be used during linking in all cases.
 >  @end defmac

Cut!  Rather, would define "compilation flags", "linking flags" and
use them "anonymously".

 >  @defmac AC_TRY_LINK_FUNC (@var{function}, @ovar{action-if-found}, 
 > @ovar{action-if-not-found})




reply via email to

[Prev in Thread] Current Thread [Next in Thread]