Re: Find best grep for AIX

[Peter O'Gorman]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gary V. Vaughan wrote:

| Albert Chin wrote:
| | On Mon, Jan 19, 2004 at 01:39:30PM +0900, Peter O'Gorman wrote:
| |
| |>Albert Chin wrote:
| |>
| |>>>Patch against CVS head.
| |>>>
| |>>>2004-01-11  Albert Chin-A-Young  <address@hidden>
| |>>>
| |>>>    * ltmain.in, m4/libtool.m4: New LT_AC_PROG_GREP macro to
| |>>>    find best "grep" command to match the longest lines.
| |>
| |>If it is required for AIX to work properly then there is little
| |>choice but to check.
| |
| | It's not required but it helps.
| |
| |
| |>Maybe you also need to change the check for egrep?
| |
| | How about we ditch grep in favor of egrep?
|
| We already use $EGREP from AC_PROG_EGREP in autoconf which does this:
|
| ~  if echo a | (grep -E '(a|b)') >/dev/null 2>&1
| ~    then ac_cv_prog_egrep='grep -E'
| ~    else ac_cv_prog_egrep='egrep'
| ~  fi
| ~  EGREP=$ac_cv_prog_egrep
|
| So libtool's references to $EGREP are not addressed.
|
| |>I think that all uses of grep should become $GREP to be consistent.
|
| Looks like we need AC_PROG_GREP based on your patch in autoconf, and then
| AC_PROG_EGREP and AC_PROG_FGREP should AC_REQUIRE([AC_PROG_GREP]) use
| $ac_cv_prog_grep instead of grep, and perform a similar path search for
| egrep/fgrep if $GREP -E/-F don't work.
|
| The attached is the libtool portion of the patch.  Albert, can you massage
| your patch to apply to autoconf?
|
| | BTW, I'd still like to know if adding LT_AC_PROG_GREP to
| | AC_LIBTOOL_CONFIG is the correct place to put LT_AC_PROG_GREP.
|
| Nope.  Once autoconf has AC_PROG_GREP, we could add it in AC_LIBTOOL_SETUP,
| but we already have AC_PROG_EGREP, so it will be implied.
|
| Okay to apply?

Yes, although I've only skimmed it.

Why require autoconf to have the AC_PROG_GREP etc.? We've had checks like
that in libtool before while waiting on autoconf releases/integration.

Peter
- --
Peter O'Gorman - http://www.pogma.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (Darwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iQCVAwUBQA/OFLiDAg3OZTLPAQJNngQAuwe2cOSQ0z4n3kGrq45YkM0RIoqMR3fw
WI+wxhZQxo6CmCD98YJmq6u/KHt7yAPbZJtn7WZ2ls6xvgECa92Of+aoPkYbSrbl
CJpOmWMJb+BI8QE2iu6uMIY8FQlWNBdvhIBOPnEfCzZizMI9qaoEdadLknTVVcnx
tM2AeUyoHJs=
=g0OR
-----END PGP SIGNATURE-----