Re: 3-gary-new-AC_PROG_SED.patch

[Gary V . Vaughan]

Hi Paul!

On Thursday, January 22, 2004, at 07:07  pm, Paul Eggert wrote:
> Wouldn't it be simpler just to invoke
> _AS_PATH_WALK([$PATH /usr/xpg4/bin]
> and omit the two for loops?

Good call.  Yes, it would.

> Local variables should start with ac_, not _ (e.g., "ac_sed" not 
> "_sed").

Done.

> > +    echo >>conftest.nl
>
> I vaguely recall that plain "echo" outputs nothing on some hosts.
> "echo ''" is safer.

Okay.

> > +    $_sed -e 's/a$//' < conftest.nl >conftest.out || break
> > +    cmp -s conftest.out conftest.nl || break
>
> Is cmp -s portable?  It might be more portable to use plain "cmp"
> and redirect output to /dev/null.

I dunno, but it can't hurt to err on the side of caution.

> > +    # 10000 chars as input seems more than enough
> > +    test $_count -gt 10 && break
>
> This comment is confusing as the "10" and the "10000" seem linked,
> but they're not really.

Well they are, it just isn't obvious how :-)

> Could you please resubmit after addressing the above issues?  Thanks.

Attached.

Cheers,
        Gary.
--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://www.oranda.demon.co.uk
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

3bis-gary-new-AC_PROG_SED.patch
Description: Binary data

PGP.sig
Description: This is a digitally signed message part