Re: 4-gary-AC_PROG_GREP.patch [Was Re: Find best grep for AIX]

[Gary V . Vaughan]

Hi Paul!

Thanks again for the code review :-)

On Saturday, January 24, 2004, at 07:51  am, Paul Eggert wrote:
> Second thoughts on that patch:
>
> Why change the externally visible behavior?  Wouldn't it be better to
> see the "Checking for egrep...."  messages in all cases?  With the
> above change, the code checks for $GREP -E without issuing the
> "Checking for egrep..."  message.  I think the original behavior
> was better.

Good catch.  That was just me being sloppy when moving code around.  I 
hadn't
intended to drop that behaviour.  Restored in this version.

> AC_PROG_GREP and AC_PROG_SED seem to be sharing a lot of code;
> shouldn't it be factored out?

I had meant for _AC_PATH_PROG_FEATURE_CHECK to be that... but you're 
right, after
some more thought I managed to move the macro definition boundaries 
around
without having the macros need to know too much about one another's 
implementation.
Where there are shared secrets, I've made them explicit in the 
doc-comments.  I
like this version much better.

 $ ./testsuite -v 128 134
 ## ------------------------------ ##
 ## GNU Autoconf 2.59a test suite. ##
 ## ------------------------------ ##
 128. acprograms.at:13: testing ...
 acprograms.at:13: autoconf -W obsolete
 acprograms.at:13: /bin/sh -n configure
 acprograms.at:13: autoheader
 acprograms.at:13: top_srcdir=$abs_top_srcdir ./configure
 stdout:
 checking for grep that handles long lines... /usr/bin/grep
 checking for fgrep... /usr/bin/grep -F
 configure: creating ./config.status
 config.status: creating config.h
 acprograms.at:13: cat state-ls.after
 128. acprograms.at:13: ok

 134. acprograms.at:19: testing ...
 acprograms.at:19: autoconf -W obsolete
 acprograms.at:19: /bin/sh -n configure
 acprograms.at:19: autoheader
 acprograms.at:19: top_srcdir=$abs_top_srcdir ./configure
 stdout:
 checking for sed that does not truncate output... /usr/bin/sed
 configure: creating ./config.status
 config.status: creating config.h
 acprograms.at:19: cat state-ls.after
 134. acprograms.at:19: ok
 ## ------------- ##
 ## Test results. ##
 ## ------------- ##
 All 2 tests were successful.

Okay to apply?

Cheers,
        Gary.
--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://www.oranda.demon.co.uk
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

4ter-gary-AC_PROG_GREP.patch
Description: Binary data