Re: Be done with AU_DEFUN's third argument

[Alexandre Duret-Lutz]

>>> "Paolo" == Paolo Bonzini <address@hidden> writes:

 Paolo> AFAICT even the first revision that is in CVS of autoupdate did not
 Paolo> output the messages, so I took some liberties in the implementation.
 Paolo> What this patch does is:

 Paolo> 1) move all the AC_DIAGNOSE in AU_DEFUN'd macros to the infamous third
 Paolo> parameter.

 Paolo> 2) in autoupdate, trace AU_DEFINE instead of AU_DEFUN.

 Paolo> 3) in AU_DEFUN, spit out the warning just once, but include the
 Paolo> AC_DIAGNOSE in every instance of the macro.  This way, one can
 Paolo> simply search the autoupdated configure.ac for AC_DIAGNOSE in order
 Paolo> to find places that needs work (AC_LINK_FILES may appear multiple
 Paolo> times).

 Paolo> It also removes the notices about the brokenness of the third
 Paolo> parameter that I put in when I reverted my original patch.

 Paolo> No problem for me if you got confused, I admit I was not very clear
 Paolo> because I was not sure if it worked by accident...  It looks much
 Paolo> better now.

This patch seems to have just gone in, and I think it is causing
autoupdate to output confusing warnings (see below).

I tried to look at AU_DEFUN, but I do not understand it.  It
would be nice to document its logic.  Also the comments say "See
`acobsolete.m4' for a longer description." but I could not find
this file, even in the ChangeLog.

This is with Autoconf 2.59

% cat configure.ac
AC_INIT
AC_ARG_ARRAY
% autoupdate
% cat configure.ac
AC_INIT
AC_DIAGNOSE([obsolete],[AC_ARG_ARRAY: no longer implemented: don't do 
unportable things
with arguments. Remove this warning when you adjust your code.])

Now here is CVS Autoconf

% cat configure.ac
AC_INIT
AC_ARG_ARRAY
% autoupdate
/tmp/au9JeqMQ/input.m4:99: warning: _au_warn_AC_ARG_ARRAY is no longer 
implemented: don't do unportable things
with arguments. Remove this warning when you adjust your code.
% cat configure.ac
AC_INIT
AC_DIAGNOSE([obsolete],[AC_ARG_ARRAY is no longer implemented: don't do 
unportable things
with arguments. Remove this warning when you adjust your code.])dnl
-- 
Alexandre Duret-Lutz