autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Warn on naked cross-tool names, add macros to detect target tools


From: Paul Eggert
Subject: Re: Warn on naked cross-tool names, add macros to detect target tools
Date: 17 Mar 2004 12:06:09 -0800
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3

Bonzini <address@hidden> writes:

> For target tools, it makes no sense to me to have naked names, so I
> am already looking for prefixed names only.

Thanks for following up on this.

> -^AC_CHECK_(ALIGNOF|DECL|FILE|FUNC|HEADER|LIB|MEMBER|PROG|SIZEOF|TOOL|TYPE)S?$
> +^AC_CHECK_(ALIGNOF|DECL|FILE|FUNC|HEADER|LIB|MEMBER|PROG|SIZEOF|.*TOOL|TYPE)S?$

This part of the patch seems a overbroad: can you please fix the
pattern so that it identifies only the macros in question?

Also, the new doc seems to have lost a bit of the juice that motivated
the change.  I suspect a naive reader won't understand the need for
AC_CHECK_TARGET_TOOL etc.  A specific example would help, particularly
if it could illustrate the problem with the old approach.

The other issues in this discussion seem to be: improving the
description a bit, and "downgraded" ("broken"?) builds.  Perhaps the
new doc could include an example about that too.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]