autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix parsing of Fortran -v output in Portland-Group compiler


From: Paul Eggert
Subject: Re: fix parsing of Fortran -v output in Portland-Group compiler
Date: Sat, 27 Mar 2004 21:31:58 -0800
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)

"Steven G. Johnson" <address@hidden> writes:

> On Sat, 27 Mar 2004, Paul Eggert wrote:
>> Looks good, but can you uniformly replace [[^\"]] by [[^\\"]] while
>> you're installing it?  Some sed's mishandle backslashes inside bracket
>> expressions.  There are two instances of this in fortran.m4 after your
>> patch.  Thanks.
>
> Hmm, just to be clear, this regexp was intended to match any character
> that is not a quote, I think (in both instances).  Doesn't [^\\"] match
> any character that is not a quote or a backslash?  Should it be simply
> [^"], if the backslash is truly not needed before the quote?

Yes it should.

Looking at the old line again (for the *mGLOB_options_string* case):

    ac_[]_AC_LANG_ABBREV[]_v_output=`echo $ac_[]_AC_LANG_ABBREV[]_v_output | 
sed 's/\"-mGLOB[[^\"]]*\"/ /g'` ;;

None of the backslashes are necessary in this line, and they all lead
either to undesirable behavior (in the case you noted) or to undefined
behavior (using \" outside a bracket expression).  All the backslashes
should be removed from this line.  (It appears to me that someone
replaced the quoting (") by (') without replacing internal (\") with
(").)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]