Re: Autotest: make test dir writable before removing

[Stepan Kasal]

Hello,

On Sun, Oct 02, 2005 at 02:46:06PM -0700, Paul Eggert wrote:
> Ralf Wildenhues <address@hidden> writes:
> 
> >     * lib/autotest/general.m4 (AT_INIT): Make test dir content
> >     writable before removing.
> 
> I have a few qualms about invoking "chmod u+w" as I worry it might run
> afoul of people who have deliberately set up their directories in
> weird ways.

The command is executed just before "rm -rf", thus I believe there is no real
danger.

> chmod -R is portable these days, by the way.

Then I think the patch is OK.

I applied Ralf's patch, together with a cosmetic change at the end of AT_INIT,
see below.

(If there is something we (Ralf and I) have missed, we can revert the change
later, of course.)

Have a nice day,
        Stepan

2005-10-02  Ralf Wildenhues  <address@hidden>
            Stepan Kasal  <address@hidden>

        * lib/autotest/general.m4 (AT_INIT): Make test dir content writable
        before removing.  Remove an errorneous comment from the end, where
        the logs of the failed tests are copied to the main log file.

Index: lib/autotest/general.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/autotest/general.m4,v
retrieving revision 1.190
diff -u -r1.190 general.m4
--- lib/autotest/general.m4     23 Aug 2005 08:57:24 -0000      1.190
+++ lib/autotest/general.m4     3 Oct 2005 10:16:29 -0000
@@ -669,6 +669,7 @@
       # Create a fresh directory for the next test group, and enter.
       at_group_dir=$at_suite_dir/$at_group_normalized
       at_group_log=$at_group_dir/$as_me.log
+      chmod -R u+w $at_group_dir
       rm -f -r $at_group_dir
       mkdir $at_group_dir ||
        AS_ERROR([cannot create $at_group_dir])
@@ -925,12 +926,9 @@
       echo
       for at_group in $at_fail_list
       do
-        # Normalize the test group number.
+        # Normalize the test group number and cat the log.
         at_group_normalized=`expr "00000$at_group" : ".*\($at_format\)"`
-        # Create a fresh directory for the next test group, and enter.
-        at_group_dir=$at_suite_dir/$at_group_normalized
-        at_group_log=$at_group_dir/$as_me.log
-        cat "$at_group_log"
+        cat "$at_suite_dir/$at_group_normalized/$as_me.log"
         echo
       done
       echo