Re: Autotest: make test dir writable before removing

[Ralf Wildenhues]

Hi Stepan,

* Stepan Kasal wrote on Tue, Oct 04, 2005 at 11:15:01AM CEST:
> On Mon, Oct 03, 2005 at 12:41:04PM -0700, Paul Eggert wrote:
> > I was worried about the case where it wasn't erased, and where the
> > test contained a symlink to /usr/bin or something like that.
> > Admittedly I'm waving my hands a bit here; I don't know exactly what
> > I'm worried about.
> 
> I cannot imagine a real danger with links.

See my other reply -- symlinks to files may cause modes of files outside
the test dir to be changed (tested on Solaris).

> > > I guess we have to put in the trap in order to provide backward
> > > compatibility with 2.59, but only for that reason.
> > 
> > Yes, that's right.
> 
> First, I have to admit that I don't understand this, so I cannot fix it.

I meant to say: "Even if CVS Autoconf has this fixed, Libtool needs to
add a workaround to its present tests in order to maintain compatibility
with Autoconf-2.59".

> But I understand this, so I implemented it.  I committed another patch,
> as attached to this mail.

AFAICS, it leaves the symlink problem unaddressed.

Cheers,
Ralf

> 2005-10-04  Stepan Kasal  <address@hidden>
> 
>       * lib/autotest/general.m4 (AT_INIT): Really make the subtree writable
>       before removing it (chmod -R u+rwx); there are three instances of this.