Re: uninitialized variables

[Paul Eggert]

Ralf Wildenhues <address@hidden> writes:

> +  tmp=
>    trap 'exit_status=$?; rm -fr "$tmp" && exit $exit_status' 0

On ancient systems, "" is an alias for ".", so can you please change
the code to check whether tmp is empty?  Also, we should check that
$tmp is a directory, for the same reason that AS_TMPDIR does.
Something like this, perhaps?

trap '
  exit_status=$?
  { test -z "$tmp" || test ! -d "$tmp" || rm -fr "$tmp"; } && exit $exit_status
' 0

This code still has a race condition, as tmpdir might not get cleaned
up if the script is interrupted between the time the directory is made
and $tmp is assigned to.  Perhaps that could be in a comment somewhere.


>         * lib/autoconf/general.m4 (_AC_INIT_DEFAULTS): Initialize
>         ac_clean_files and LIBOBJS.

That looks good to me; please install.