Re: Debian-specific Autoconf patches

[Stepan Kasal]

Hello Paul,

On Thu, May 25, 2006 at 09:57:02AM -0700, Paul Eggert wrote:
> Here's a heads-up on the patch, to give you a feeling for what's needed.
> I still need to add some comments and ChangeLog entries and whatnot.

thank you very much for this work.

I'm afraid it would be too dangerous for 2.60, so I suggest that we
commit the documentation part, plus the two fixes to  AC_TRY_COMMAND
calls, and leave the rest after the release.  Ralf, would you agree?

Two nits:

> +++ lib/autoconf/status.m4    25 May 2006 16:54:57 -0000
...
>    ac_prev=
> -  eval set x "$ac_configure_args"
> +  eval "set x$ac_configure_args"

I would make it
     eval "set x $ac_configure_args"

It is more readable, since there is no need to recall that
$ac_configure_args always starts with space.

For the same reason, I'd revert the following change:

> +++ lib/autoconf/general.m4   25 May 2006 16:54:57 -0000
> @@ -1501,7 +1504,7 @@ for ac_var in $ac_precious_vars; do
>      *\'*) ac_arg=$ac_var=`echo "$ac_new_val" | sed "s/'/'\\\\\\\\''/g"` ;;
>      *) ac_arg=$ac_var=$ac_new_val ;;
>      esac
> -    case " $ac_configure_args " in
> +    case "$ac_configure_args " in
>        *" '$ac_arg' "*) ;; # Avoid dups.  Use of quotes ensures accuracy.
>        *) ac_configure_args="$ac_configure_args '$ac_arg'" ;;
>      esac

Have a nice day,
        Stepan