[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Manual handling of arguments
From: |
Eric Blake |
Subject: |
Re: Manual handling of arguments |
Date: |
Tue, 21 Aug 2007 14:00:54 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Ralf Wildenhues on 8/21/2007 12:30 PM:
> Hello Olaf, and sorry for the delay,
Hello Ralf, and thanks for working on this,
> Here's a patch to try, including a test to help ensure that we don't
> regress here again. OK to apply?
The patch looks fine. Go ahead and commit.
>
> FWIW, the test isn't as good as it could be: through diversion, code
> can be pushed up to the initialization stage due to macros invoked
> later. I don't see a good way to guard for future code (that could
> be in a new macro that uses diversions) and I didn't find at a rough
> glance any other existing macro in Autoconf that could break this.
I couldn't think of anything either, other than grepping the autoconf
source for 'set [^-]', which didn't seem much more reliable.
> * lib/autoconf/general.m4 (AC_SITE_LOAD): Do not overwrite "$@"
> here, this macro is expanded by AC_INIT. Fixes 2.60 regression.
> * tests/base.at (configure arguments): New test.
> Report by Olaf Lenz <address@hidden>.
Don't forget to update THANKS.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGy0R284KuGfSFAYARAusQAKDNVNe6gSEAsXP+EVfTuVEFv0AVhQCgpA/W
005f+E8UwdQXlTZnUvMDK5A=
=8ACR
-----END PGP SIGNATURE-----