autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: install-sh executability


From: Eric Blake
Subject: Re: install-sh executability
Date: Sat, 22 Sep 2007 07:14:50 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Eric Blake-1 on 9/18/2007 10:50 AM:
> Rather than add $(SHELL) to @MKDIR_P@, what if we take the
> approach of guaranteeing that install-sh is executable?
> Does anyone spot issues with the following patch?
>
> 2007-09-18  Eric Blake  <address@hidden>
>
>       Ensure that install-sh is executable.
>       * lib/autoconf/general.m4 (AC_CONFIG_AUX_DIRS): Add config.status
>       hook for install-sh.

I withdraw this patch - as Ralf guessed, it has the potential to break on
read-only $srcdir.  However, would an alternate patch be appropriate, that
in addition to checking for the presence of install-sh, also adds a
warning if install-sh is not executable?  This seems less invasive than
trying to figure out how to support $SHELL in the INSTALL and MKDIR_P
definitions.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG9RVK84KuGfSFAYARAt7ZAJ9u3HnrbxAo8FivdOnA6bFT+KSZ5wCfQDVx
jfwWUv2MQwGaDpscxmPgRJo=
=5O5m
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]