Re: Fix chdir-long.m4 caching

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Eric Blake on 9/27/2007 10:32 PM:
>>      * tests/local.at (AT_CHECK_M4): Fix for cases when the past
>>      parameter is `stderr' or `experr'.
> 
> Applied as follows:
> 
> @@ -96,15 +96,15 @@ m4_define([AT_CHECK_PERL_SYNTAX],
>  # remove the error code during normalization.
>  #
>  m4_define([AT_CHECK_M4],
> -[AT_CHECK([$1], [$2], [$3], m4_ifval([$4], [stderr]))
> -m4_ifval([$4],
> +[AT_CHECK([$1], [$2], [$3], m4_if([$4], [], [], [ignore], [ignore],
[stderr]))

Ouch.  I failed to notice the bug in the above.  What I meant was either:
m4_if([$4], [], [], [$4], [ignore], [ignore], [stderr])
or what I'm checking in:
m4_case([$4], [], [], [ignore], [ignore], [stderr])

+m4_if([$4], [], [], [ignore], [],

And likewise.  While the former one was basically a no-op over the
previous state, this line actually caused some testsuite regressions
(serves me right for running only a subset of the testsuite before
checking in, and happening to have an environment where the m4 output was
already normalized).

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG/O7P84KuGfSFAYARAsdnAKCtc9PeiMKA46PbJNwBT1lX3JQwJwCfQKjc
geS2XP98xbA2VDU8RFzk4Zg=
=P0gc
-----END PGP SIGNATURE-----