[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch proposal: Add --clean options to unbootstrap a project.
From: |
Eric Blake |
Subject: |
Re: Patch proposal: Add --clean options to unbootstrap a project. |
Date: |
Sun, 30 Sep 2007 15:40:29 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Ralf Wildenhues on 9/30/2007 10:21 AM:
>
>> + {
>> + unlink $f or error "error: Cannot remove `$f': $!"
>> + unless not -f $f;
>
> FWIW, this kind of code leaves me wondering about perl operator
> precedence. Is `unless' an operator (it's not listed in `perldoc
> perlop') and what's the binding here? (I did test it to ensure it's
> right here, and left it this way.)
In perl, "unless expression" is a statement, strictly equivalent to "if !
expression", ie. the same precedence as if, but reads nicer in English
when avoiding double negatives.
>
> Autoconf:
> 2007-09-30 Benoit Sigoure <address@hidden>
> Ralf Wildenhues <address@hidden>
>
> * bin/autoconf.as, bin/autoheader.in, bin/autoreconf.in,
> bin/autom4te.in, bin/autoscan.in, bin/autoupdate.in: New option
> `--clean', short `-c'.
As to the rest of this patch, it will be a couple of days before I can
take a better look into it. But thanks for your efforts on this front.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHABfM84KuGfSFAYARAuQjAKCWrPoBD3qu0HRuM51GDdqNqQCl3wCeO0Yc
y99QnCb/+OkvcNZmc1WAHdo=
=+MeV
-----END PGP SIGNATURE-----