[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: testsuite -C dir

From: Eric Blake
Subject: Re: testsuite -C dir
Date: Mon, 28 Jan 2008 13:50:49 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20071031 Thunderbird/ Mnenhy/

Hash: SHA1

According to Ralf Wildenhues on 1/28/2008 1:37 PM:
| [...]
|> @@ -361,31 +361,6 @@ fi
|>  ## ---------------------- ##
|>  m4_divert_pop([PREPARE_TESTS])dnl back to DEFAULTS
|> -# Load the config file.
|> -for at_file in atconfig atlocal
|> -do
|> -  test -r $at_file || continue
|> -  . ./$at_file || AS_ERROR([invalid content: $at_file])
|> -done
| Isn't this an API change?  It looks to me the at* files are now
| interpreted after the command line (untested).  That seems wrong:
| the command line should override atlocal, if I do
|   ./testsuite PERL=/some/other/perl

Ouch.  I think you're right.  The problem which drove me to move this
snippet was that unless atconfig lives in the same directory where you
invoke testsuite, it does not get sourced, which is not what we want
either (in the case of m4, it meant that running tests/testsuite did not
discover the default AUTOTEST_PATH=tests in $(builddir)/tests/atconfig,
and therefore, the test was being run on the installed m4 rather than the
just-built m4).

I guess the correct solution is to look for atconfig in the current
directory (as was the case before my regression) as well as in dirname
"$at_myself" (which may be the same directory), before declaring that it
can't be found.  I'll work on a patch along those lines.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at
Comment: Using GnuPG with Mozilla -


reply via email to

[Prev in Thread] Current Thread [Next in Thread]