[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: interrupt causes parse error in configure script

From: Jim Meyering
Subject: Re: interrupt causes parse error in configure script
Date: Mon, 18 Aug 2008 12:12:29 +0200

Ralf Wildenhues <address@hidden> wrote:
> Hi Jim,
> * Jim Meyering wrote on Mon, Aug 18, 2008 at 11:23:01AM CEST:
>> I admit that this not a big deal, but even when I interrupt a configure
>> script, I prefer to see it die cleanly.  Otherwise, I have to wonder
>> if some clean-up trap code also fails to run.
>> Comments, suggestions ?
> Doesn't this patch hide potential typos otherwise exposed by the `test'
> error?  AIUI gnulib uses this idiom a lot.

Good point!
Here's an incremental to fix that:

diff --git a/lib/m4sugar/m4sh.m4 b/lib/m4sugar/m4sh.m4
index afa747a..bc2a919 100644
--- a/lib/m4sugar/m4sh.m4
+++ b/lib/m4sugar/m4sh.m4
@@ -1548,7 +1548,7 @@ m4_define([AS_VAR_SET],
 # --------------------
 # test whether VARIABLE has value "yes".
-[as_yes=AS_VAR_GET([$1]); test "x$as_yes" = xyes])
+[as_yes=AS_VAR_GET([$1]); test "$as_yes" = yes])


reply via email to

[Prev in Thread] Current Thread [Next in Thread]