[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [SCM] GNU Autoconf source repository branch, master, updated. v2.63b

From: Ralf Wildenhues
Subject: Re: [SCM] GNU Autoconf source repository branch, master, updated. v2.63b-69-g9a15f2f
Date: Wed, 8 Jul 2009 07:27:19 +0200
User-agent: Mutt/1.5.20 (2009-06-15)

Hi Eric,

* Eric Blake wrote on Wed, Jul 08, 2009 at 06:57:17AM CEST:
> --- a/lib/autotest/general.m4
> +++ b/lib/autotest/general.m4

> @@ -1362,7 +1361,7 @@ dnl         kill -13 $$
>        at_fn_group_prepare
>        if cd "$at_group_dir" &&
>        at_fn_test $at_group &&
> -      . "$at_test_source" # AT_JOB_FIFO_FD<&-
> +      . "$at_test_source" # AT_JOB_FIFO_FD>&-
>        then :; else
>       AS_WARN([unable to parse test group: $at_group])
>       at_failed=:

This hunk is actually wrong, and I don't remember seeing it in the
first iteration of your patch.  Of course, since it only changes a
comment, it is not relevant.  However, you cannot close the fd for
writing here, because a PIPE signal (that could happen within a test
group for completely unrelated reasons) will cause the process to try
to use it.  It's only the reading end that would be unused here (but
of course the notation would close the fd for either use).

I think it's best to remove the comment, or change the trap to output
to $at_job_fifo rather than the fd.  I haven't tried that, though.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]