[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] introduce AT_SKIP_IF and AT_FAIL_IF

From: Ralf Wildenhues
Subject: Re: [PATCH] introduce AT_SKIP_IF and AT_FAIL_IF
Date: Sun, 12 Jul 2009 15:54:19 +0200
User-agent: Mutt/1.5.20 (2009-06-15)

Hi Paolo,

* Paolo Bonzini wrote on Sun, Jul 12, 2009 at 01:09:54PM CEST:
> --- a/doc/autoconf.texi
> +++ b/doc/autoconf.texi
> @@ -22653,6 +22653,42 @@ Writing Testsuites
>  Several identical calls within one test group have no additional effect.
>  @end defmac
> address@hidden AT_FAIL_IF (@var{shell-condition})
> address@hidden
> +Make the test should fail and skip the rest of its execution if

s/should/group/  ?

> address@hidden is true.   @var{shell-condition} a shell expression

s/ a / is&/  =

Two spaces after period are normal.  More instances below.

> +such as a @code{test} command.   Tests before @command{AT_FAIL_IF}
> +will be executed and may still cause the test group to be skipped.
> +You can instantiate this macro many times from within the same test group.
> +
> +You should use this macro only for very simple failure conditions.  If the
> address@hidden could emit any kind of output you should instead
> +use @command{AT_CHECK} like
> address@hidden
> +AT_CHECK(address@hidden || exit 99)
> address@hidden example
> address@hidden
> +so that such output is properly recorded in @file{testsuite.log}.

in the @file{testsuite.log} file.

> address@hidden defmac

I haven't looked at the implementations in detail, but at a ten second
glance this and your other patches all looked basically sane to me.
I'm sure Eric will provide a much better review.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]