[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch to add autotests for Erlang macros

From: Eric Blake
Subject: Re: patch to add autotests for Erlang macros
Date: Thu, 23 Jul 2009 20:39:49 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20090605 Thunderbird/ Mnenhy/

Hash: SHA1

According to Romain Lenglet on 7/23/2009 8:44 AM:
> On Thursday 23 July 2009 22:57:36 Romain Lenglet wrote:
>> This allows us to test all the macros using AT_CHECK_MACRO, which is much
>> cleaner and concise.
>> Cf. the attached diff against the latest master branch.
>> Sorry for the delay for sending you that patch!
> Ooops, scratch that.
> That latest patch was buggy, sorry.
> Attached is a working version of that latest patch.

More tweaks needed.  Your changelog entry should call out macro names
affected (sorry I didn't catch that last time).  'test ... -o ...' is not
portable, you must use 'test ... || test ...'.  Also, 'git format-patch'
gives nicer output that 'git diff'; in part because it includes the author
name and date and commit message.  I'm guessing that the deletion in
tests/ was intentional, since your ChangeLog didn't mention it.

At any rate, I've applied this (if for no other reason than the namespace
improvement is good); please review again.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at
Comment: Using GnuPG with Mozilla -


reply via email to

[Prev in Thread] Current Thread [Next in Thread]