[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch to add AT_CHECK_EUNIT autotest macro

From: Paolo Bonzini
Subject: Re: patch to add AT_CHECK_EUNIT autotest macro
Date: Fri, 31 Jul 2009 09:12:26 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

This is a good idea.  Right now the amount of allowed changes in Autoconf
is very limited, but I'd like to hear from Ralf as well.

The macro requires variables ERL, ERLC, and ERLCFLAGS to be defined. I
documented that those should be configured by configure, and I modified
the generated atconfig file to contain those configured values. It's
simple and transparent, but may be ugly since those will be defined for
all testsuites, even those that don't use AT_CHECK_EUNIT. Any suggestion
to make it better? And should I exit with code 99, in AT_CHECK_EUNIT, if
those variables are not defined?

No, probably with code 77 (skip the testcase if EUnit is not installed).

Also, sorry for the form of this email.
I am sending this pach manually from a system without git.

This is not a problem. Just ensure that the patch is attached as text/plain and not application/octet-stream, please. (This is why I have not yet looked at it, even though I will later).

If you want to fiddle with the email settings, you can send the patch to me again privately to see if you got those settings right. (This will save me time overall).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]