Re: unoptimized autoconf generated code

[Eric Blake]

According to Ralf Wildenhues on 3/2/2010 2:45 PM:
> Hi Eric,
> 
> * Eric Blake wrote on Tue, Mar 02, 2010 at 07:04:52AM CET:
>> Here's an updated version of patch 2/3 of the previous post; I realized
>> that ${a+b} should not be treated as a simple indirection, and added some
>> documentation.  Patch 1/3 and 3/3 are unchanged.
> 
> This patch causes a number of testsuite regressions.  The AS_BOX patch
> has a typo s/@var/@ovar/ in the manual causing a texinfo warning.

Thanks for a review.  Certainly still a work in progress, and I won't
commit without a complete successful testsuite run.

> 
> While working on AS_LITERAL_IF, you might want to fix the typo near the
> beginning of the description:
>   # If EXPRESSION has shell indirections ($var or `expr`), expand
>   # IF-LITERAL, else IF-NOT-LITERAL.
> 
> That should be "has no shell indirections".

Yep.

> 
> If you're really motivated, then you could also look into this code
> snippet taken from the manual:
> 
>   header="sys/some file.h"
>   AS_TR_SH([HAVE_$header])=yes
>   if test "x$HAVE_sys_some_file_h" = xyes; then echo "Have it!"; fi
> 
> which has been broken presumably by one of the earlier AS_LITERAL_IF
> changes already.  (This is not a recent regression, so feel free to
> ignore right now.)

Actually, it's a doc bug.  This is not valid shell variable assignment:

`echo $foo`=yes

So this patch is going in now, while I spend more time fixing the actual
code changes.

-- 
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden

autoconf.patch261
Description: Text document

signature.asc
Description: OpenPGP digital signature