[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Testsuite coverage for 'Caching Results' section.

From: Eric Blake
Subject: Re: Testsuite coverage for 'Caching Results' section.
Date: Mon, 07 Jun 2010 19:20:13 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100430 Fedora/3.0.4-3.fc13 Lightning/1.0b2pre Mnenhy/0.8.2 Thunderbird/3.0.4

On 06/06/2010 05:45 AM, Ralf Wildenhues wrote:
> [ ]
> * Ralf Wildenhues wrote on Mon, Mar 01, 2010 at 11:01:04PM CET:
>> This is not for 2.66, even if it gets done before the release.
> Well, but since it's been a while, and the patch is fairly low danger,
> I'll ping it anyway.  OK to commit?  Now or after 2.66?

Thanks for the ping.

I'm (obviously) visiting autoconf again this week (I've got some spare
time in my evenings for a few days), so maybe I'll make better progress
on my promise to get a release out the door this time around.

> Thanks,
> Ralf
>>     Testsuite coverage for AC_CACHE_VAL and caching semantics.
>>     * tests/ (AC_CACHE_CHECK): Extend test.
>>     (AC_CACHE_LOAD): New test.
>>     * tests/ (Configuring subdirectories): Also test
>>     --config-cache with AC_CONFIG_SUBDIRS.

This is low-risk - either the new tests pass, or they don't and we
figure out why; you aren't changing semantics.

>>     * doc/autoconf.texi (Caching Results): Annotate code snippets
>>     which are tested in the test suite.
>>     (Cache Files): Documented cache variables may be used on the
>>     configure command line to override individual entries in the
>>     cache file.

I particularly liked the strategic comments in the manual to point us
back to the testsuite.

I've read through the patch now, and think that it is appropriate to add
prior to 2.66.  Push at will.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]