Re: [PATCH 2/2] maint: drop 'Automake::Struct' module

[Eric Blake]

On 03/05/2012 12:20 PM, Stefano Lattarini wrote:
> On 03/05/2012 02:18 PM, Eric Blake wrote:
>> On 03/04/2012 08:14 AM, Stefano Lattarini wrote:
>>> Now that we require Perl 5.6.2, we can drop the 'Automake::Struct'
>>> module, which was basically just a backport of Perl 5.6's
>>> 'Class::Struct' to Perl 5.5.
>>>
>>> * automake.in: Use 'Class::Struct', not 'Automake::Struct'.
>>> * lib/Automake/Struct.pm: Delete.
>>> * lib/Automake/Makefile.am (dist_perllib_DATA): Remove it.
>>> ---
>>>  automake.in              |    5 +-
>>>  lib/Automake/Makefile.am |    1 -
>>>  lib/Automake/Struct.pm   |  627 
>>> ----------------------------------------------
>>>  3 files changed, 3 insertions(+), 630 deletions(-)
>>>  delete mode 100644 lib/Automake/Struct.pm
>>
>> You are missing the corresponding tweak to cfg.mk to quit importing
>> Struct.pm from automake (that is, 'make fetch' must not revive the
>> file).  ACK series with that additional tweak.
>>
> You mean something like the attached patch?

Yep - feel free to push now.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature