Re: [PATCHv3] m4sugar: factor away _AS_ECHO_PREPARE.

[Eric Blake]

On 01/29/2013 11:26 AM, Stefano Lattarini wrote:
> Hello everybody, sorry for the late review.
> 
> On 01/29/2013 07:17 AM, Gary V. Vaughan wrote:
>> Incorporating feedback from Paul and Paul.  Thank you both :)
>>

>> @@ -461,6 +460,9 @@ _AS_PATH_SEPARATOR_PREPARE
>>  # there to prevent editors from complaining about space-tab.
>>  # (If _AS_PATH_WALK were called with IFS unset, it would disable word
>>  # splitting by setting IFS to empty value.)
>> +as_nl='
>> +'
>> +export as_nl
>>
> Why this export?

Because _AS_ECHO_PREPARE used to export it as well.  Removing the export
might break behavior.

>>  
> This won't work as expected with some invocation like:
> 
>   AS_ECHO([1 2 3])
> 
> as the generated code will print:
> 
>   1
>   2
>   3
> 
> rather than the (IMHO) expected:
> 
>   1 2 3
> 
> This is *not* a regression, since this issue was already in the
> existing code; but it would be nice to have it fixed in a follow-up
> patch.

No, I don't see any reason to change long-standing behavior, since no
one should be relying on the behavior when passing more than one shell
word anyway.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature