autoconf
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Incorrect use of USE_XATTR in coreutils-8.4


From: Jim Meyering
Subject: Re: Incorrect use of USE_XATTR in coreutils-8.4
Date: Fri, 22 Jan 2010 18:09:45 +0100

Eric Blake wrote:
> According to Jim Meyering on 1/22/2010 6:17 AM:
>> However, it'd sure be nice to use something more generic than
>> lib/config.h.  IMHO, autoconf should make configure AC_SUBST its
>> currently-internal-only CONFIG_HEADERS variable.  While we wait,
>> I suppose we can kludge it by extracting the first file name
>> from the use of AC_CONFIG_HEADER(S)? in configure.ac.
>
> And what's wrong with AH_HEADER?  It should be possible to do something
> like (untested):
>
> AC_CONFIG_COMMANDS_PRE([m4_ifdef([AH_HEADER],
>  [AC_SUBST([CONFIG_HEADER], m4_defn([AH_HEADER]))])])

I didn't know we could do that ;-)
And it's even documented.
Thanks!

Then, to enable maint.mk to rely on a definition of $(CONFIG_HEADER)
we could add something like the above to modules/maintainer-makefile:

    configure.ac:
    AC_CONFIG_COMMANDS_PRE([m4_ifdef([AH_HEADER],
      [AC_SUBST([CONFIG_HEADER], m4_defn([AH_HEADER]))])])




reply via email to

[Prev in Thread] Current Thread [Next in Thread]