[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AC_CHECK_DECLS(basename) (Was: Re: Ping: patches required for --enab

From: Paolo Bonzini
Subject: Re: AC_CHECK_DECLS(basename) (Was: Re: Ping: patches required for --enable-build-with-cxx)
Date: Wed, 17 Feb 2010 18:46:21 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.1

On 02/17/2010 04:41 PM, Joern Rennecke wrote:
Quoting Ralf Wildenhues <address@hidden>:
sed alternation \| is not portable.

I've replaced it now with a pair of substitutions. I also fixed
the ',' substitution to give yield on opening bracket for the next cast,
and to apply for all commas.

+ $[]as_decl_type

What is this variable? It doesn't seem to be defined anywhere.

Oops, that's a remnant from a previous implementation approach - I
originally intended of declaring a variable with the type of the
argument. That might work for more cases than casting 0 to the desired
type, but supporting multiple arguments would be much messier.

Maybe we can use this in AC_CHECK_DECLS instead of having a new separate macro. If there is a parenthesis in the name call the new version, if there is none, call the old one.

If it is fine, I can do the patch using Joern's work; thanks for it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]