[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: confdefs.h not being included by AC_LANG_SOURCE()

From: Ralf Wildenhues
Subject: Re: confdefs.h not being included by AC_LANG_SOURCE()
Date: Wed, 3 Mar 2010 07:22:30 +0100
User-agent: Mutt/1.5.20 (2009-10-28)

* Eric Blake wrote on Tue, Mar 02, 2010 at 11:48:54PM CET:
> According to Ralf Wildenhues on 3/2/2010 2:35 PM:
> > Second, I do think this is a regression, as our documentation
> > pretty clearly states that AC_LANG_SOURCE is the one expanding
> > all the AC_DEFINEs seen so far.  I do however also think that
> > the old code was ugly and hackish.  Not sure whether it would
> > be better to go back, or go forward and announce the API change.
> I'd rather go forward.  In other words, I'm thinking of the patch below.
> Comments?

I'm fine with the patch as a stop-gap measure for now.

> > But what I do know is that we need better macro coverage here.
> The change was made back on 2008-11-03 (commit 8e27cc7f5, contained in
> autoconf 2.63b), so although it is somewhat of a regression
> (AC_LANG_CONFTEST outputs defines now, when it did not do so previously),
> there obviously aren't that many packages that try to mix-and-match their
> own LANG_CONFTEST with autoconf's LANG_SOURCE, or we might have heard
> about this issue sooner.  More test coverage is always welcome, but I'm
> okay with just documentation patches for 2.66.

OK, but do note that many packages update their build systems way less
often than once per Autoconf release cycle.

> May I ask why LB_LANG_CONFTEST was created in the first place, rather than
> sticking with the autoconf interface, or is that decision lost in history?

May I add that, wow, LB_LINUX_COMPILE_IFELSE looks pretty specialized
and, if I may, ugly.  You could both clean it up and make it faster by
having AC_REQUIREd macros that set the include path and other variables
for you, as well as the basic make command.

Other than that, you are not the first to try to use autotools for
kernel modules.  You might want to search on the autoconf, automake,
or libtool lists for prior art; sorry I don't remember more.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]