[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Eric Blake
Date: Mon, 31 Jan 2011 16:53:35 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7

On 01/31/2011 04:47 PM, Paul Eggert wrote:
> The gnulib stdbool module currently arranges to #define HAVE_STDBOOL_H if 
> necessary,
> but this symbol is never used.  This is confusing people who port Emacs
> to systems that don't run 'configure', and I'd like to remove HAVE_STDBOOL_H
> from Emacs's src/ file.
> HAVE_STDBOOL_H is defined by Autoconf's AC_HEADER_STDBOOL (and thus by 
> gnulib's,
> for compatibility with Autoconf).  The only gnulib macro that uses 
> is gnulib's AM_STDBOOL_H; the latter name is curious, as it implies that the 
> macro
> belongs to Automake, but it's a gnulib macro.
> It's a bit untidy.  How about the following idea to clean things up a bit?
> In Gnulib:
> * Rename gnulib's AC_HEADER_STDBOOL to gl_HEADER_STDBOOL.
> * Remove the AC_DEFINE([HAVE_STDBOOL_H], ...) from gl_HEADER_STDBOOL.
> * Rename gnulib's AM_STDBOOL_H to gl_STDBOOL_H.
> In Autoconf:
> * Mark AC_HEADER_STDBOOL as obsolescent, and suggest to
>   Autoconf users that in the future they use gnulib if they want to
>   be portable to pre-C99 hosts with respect to <stdbool.h>.

Works for me; keeping macros like this in sync between the two
repositories has been problematic in the past, and it matches precedence
of other macros where we have declared the autoconf version obsolete (it
will continue to exist, but is no longer guaranteed to be the most
up-to-date version, in part because detecting the problems doesn't do
much good unless you also work around them, and the workarounds fit
better in gnulib's module paradigm).

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]