[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: config.guess problem with pgcc

From: Eric Blake
Subject: Re: config.guess problem with pgcc
Date: Wed, 20 Aug 2014 11:04:52 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0

On 08/20/2014 10:15 AM, Thomas Jahns wrote:
> Hello Eric,
> On 08/20/14 18:10, Eric Blake wrote:
>>> -   eval `$CC_FOR_BUILD -E $dummy.c 2>/dev/null | grep '^LIBC'` +   eval
>>> `$CC_FOR_BUILD -E $dummy.c 2>/dev/null | sed -n '/^LIBC/{s/LIBC *=
>>> *\(.*\)$/LIBC='"'"'\1'"'"'/;p;}'`
>> Thanks for the patch. We like to keep to 80-column lines where possible; 
>> also, that sed expression is rather verbose, when compared to the 
>> equivalent:
>> eval `$CC_FOR_BUILD -E $dummy.c 2>/dev/null \ | sed -n 's/^LIBC *=
>> */LIBC=/p'`
>> I'll apply the shortened version in your name, if you agree that it still
>> works.
> I'm okay with that. I verified that your shorter version still works as 
> intended.

Oops, I totally overlooked what file you were patching.  Autoconf
doesn't maintain config.guess; you'll probably want to resubmit the
patch upstream to config-patches (cc'd), as mentioned in the header of
that file.  Once it is upstream, the next autoconf release will
automatically pick up the latest copy of that file.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]