|
From: | Peter Breitenlohner |
Subject: | Re: Implementing notrans_man_MANS |
Date: | Wed, 20 Feb 2008 14:20:04 +0100 (CET) |
On Tue, 19 Feb 2008, Ralf Wildenhues wrote:
How should I proceed, once all that is finished? Email to you and/or automake bugzilla?address@hidden is best.Are unified diffs against the autoamke-1.10.1 tarball OK?Yes.What about re-indenting existing code?Please as a separate patch if possible, and please following the already-used style.
Hallo Ralf, attached are five patches (the diffs are actually against the result of applying your patch for PR 516 from 2008-01-22): 1. patch-02-notrans_MANS-reindent: Reindentation of a section in automake.in, anticipating an additional foreach loop (it was less work to do this first). 2. patch-03-notrans_MANS-impl: The actual implementation of `notrans_'. The patch looks awful but the logic in the resulting patched file should be reasonably clear. At the same time the dependencies for `install-man%SECTION%' have been revised. All make variables not used in Makefile.am are omitted from the install/uninstall rules. All those used in the rules also appear as dependencies. One consequence: "make dist_man_MANS='bar.1 baz.5' install-man" will only work well if `dist_man_MANS' is used in Makefile.am and Automake has generated the relevant (!notrans_) part of the install-man1 and install-man5 rules. So ... ? 3. patch-04-notrans_MANS-doc: Texinfo documentation for the notrans_ prefix. 4. patch-05-notrans_MANS-test: Two new test cases for missing dependencies and the notrans_ prefix. 5. automake-1.10.1-ChangeLog: Proposed ChangeLog entry. ============== Please feel free to revise the wording in texinfo, comments, and/or ChangeLog. regards Peter Breitenlohner <address@hidden>
patch-02-notrans_MANS-reindent
Description: Text document
patch-03-notrans_MANS-impl
Description: Text document
patch-04-notrans_MANS-doc
Description: Text document
patch-05-notrans_MANS-test
Description: Text document
automake-1.10.1-ChangeLog
Description: Text document
[Prev in Thread] | Current Thread | [Next in Thread] |