Re: [PATCH] Improvements and extend tests on canonicalization.

[Ralf Wildenhues]

* Stefano Lattarini wrote on Sat, Dec 11, 2010 at 06:41:46PM CET:
> Ping on this? Reference:
>  <http://lists.gnu.org/archive/html/automake-patches/2010-09/msg00106.html>
> 
> The updated patch is attached.  I will push it in 72 hours (by tuesday
> evening) unless there are objections.

OK but ...

> --- /dev/null
> +++ b/tests/canon8.test
> @@ -0,0 +1,39 @@

> +grep foob.rquux Makefile.in # might be useful for debugging
> +grep address@hidden Makefile.in # `@' must not be transliterated ...
> +grep 'address@hidden' Makefile.in && Exit 1 # ... ever!

... these last two lines look scary: unbalanced backticks and
exclamation mark in commands.  I know that that they are not special in
comments, but the latter are special on the command line, and I don't
like surprises when cut and pasting commands from a script.  Please
avoid such inline comments, also because they hurt the eye, IMVHO.

Thanks,
Ralf