automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {tests-init} Tests defs: de-uglify code for requiring an XSI


From: Stefano Lattarini
Subject: Re: [PATCH] {tests-init} Tests defs: de-uglify code for requiring an XSI-capable shell.
Date: Mon, 13 Dec 2010 20:25:57 +0100
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

On Monday 13 December 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Mon, Dec 13, 2010 at 08:16:47PM CET:
> > On Monday 13 December 2010, Ralf Wildenhues wrote:
> > > * Stefano Lattarini wrote on Sun, Dec 12, 2010 at 10:06:58PM CET:
> > > > This is just a cosmetic patch.  I will push in 72 hours
> > > > (Wednesday evening) if nobody objects.
> > > 
> > > Please don't.  It's a feature that the code is the same as the one
> > > tested in Libtool _LT_CHECK_SHELL_FEATURES: bug-tested and all.
> > >
> > Ah, ok,  What about adding a comment about this fact then?  So that
> > someone reading the code can tell "OK, this is ugly, but for a good
> > reason indeed; better not touch it."
> 
> Sure, how about just:
>   Keep this in sync with libtool.m4:_LT_CHECK_SHELL_FEATURES.
> 
I agree.  I will add it soonish (and post a proper [FYI] massage
once I've done it).

Thanks,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]