[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 12/10] More checks on warnings/strictness in precedence ("met

From: Ralf Wildenhues
Subject: Re: [PATCH 12/10] More checks on warnings/strictness in precedence ("metawarnings").
Date: Sun, 2 Jan 2011 16:50:47 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Fri, Dec 24, 2010 at 09:21:56PM CET:
> More checks on warnings/strictness in precedence ("metawarnings").

metawarnings is not a proper word, how about just eliding the part in
parentheses?  Yes, I know I'm probably too picky on language; if it
starts bothering you, I'll offer more beer when we should meet.  ;-)

> * tests/metawarnings-win-over-strictness.test: New test, similar
> to `warnings-win-over-strictness.test', but with the explicit
> warning levels being "meta-warnings" (like `-Wall' and `-Wnone').

How about s/the explicit ...(\(.*\))/catch-all warning flags \1/
and just naming the test warning-groups-win-over-strictness.test?

> * tests/ (TESTS): Update.

> --- /dev/null
> +++ b/tests/metawarnings-win-over-strictness.test

> +# Check that, on the command line, explicitly-defined warning levels take
> +# precedence over implicit strictness-implied warnings, even when these
> +# explicit warning levels are "meta-warnings" (as `-Wall' and `-Wnone').

see above

> +# Since we are at it, throw in also *.am and *.m4 file inclusions.

also throw in

> +cat > << END
> +AC_INIT([$me], [1.0])
> +m4_include([am-init-automake.m4])
> +AC_CONFIG_FILES([Makefile])
> +# Other similar tests do not use AC_OUTPUT, so we use it here,
> +# for completness and for better coverage.


> +END
> +
> +cat > <<END
> +include
> +FOO := bar
> +END
> +
> +: >
> +echo 'AM_INIT_AUTOMAKE' >  am-init-automake.m4

double space

I'm not sure it works to put AM_INIT_AUTOMAKE in an included macro.
We definitely have places in autotools somewhere that grep for it,
but I don't know if any of those are relevant here.

> +$ACLOCAL --force
> +AUTOMAKE_fails -Werror -Wall --foreign
> +grep '^Makefile\.am:.*:=.*not portable' stderr

$sleep or remove autom4te.cache here.

> +: >
> +echo 'AM_INIT_AUTOMAKE([-Werror -Wnone gnu])' > am-init-automake.m4
> +$ACLOCAL --force

Likewise here.

You are not using command-line options here.  Is that intended?  If not,
then it seems like the test description does not fully match the action.

> +echo 'AUTOMAKE_OPTIONS = -Werror -Wnone gnits' >
> +echo 'AM_INIT_AUTOMAKE' > am-init-automake.m4
> +$ACLOCAL --force

trailing white space.

OK with that addressed.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]