[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tests: work around Tru64 sh -e issues for instspc*.test.

From: Stefano Lattarini
Subject: Re: tests: work around Tru64 sh -e issues for instspc*.test.
Date: Tue, 18 Jan 2011 23:57:24 +0100
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

On Tuesday 18 January 2011, Ralf Wildenhues wrote:
> This patch fixes all but 9 of the 76 or so instspc*.test failures on
> Tru64.  It is for the tests-init branch, or a tests-init-fixes on top of
> v1.11-395-ge118126 I guess.  I'll wait a couple of days before pushing.
The patch is ok with me (but see below).  BTW, the idea of having an
'errexit' clean `tests/defs' sounds good to me, indipendently from the
issue at hand.  But I won't go as far as asking for a separate patch ;-)

> I haven't analyzed the failure sufficiently to be able to write a patch
> for autoconf.texi yet.  But the very last hunk below makes me suspicious
> of more removals of '|| Exit 1' "just because".
IMVHO, we should just reject a shell with such an untrustworthy `set -e'
behaviour.  My pending patch "Testsuite: use $SHELL to run tests which
are shell scripts":
might be a first step in ensuring that the automake tesuite is run with
a "sane" shell (if that's available).

That said, ATM I'd just apply your patch, it's definitely worth to have
if it removes 60-70 spurious test failures!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]