[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tests: work around Tru64 sh -e issues for instspc*.test.

From: Ralf Wildenhues
Subject: Re: tests: work around Tru64 sh -e issues for instspc*.test.
Date: Thu, 20 Jan 2011 21:50:09 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Ralf Wildenhues wrote on Wed, Jan 19, 2011 at 07:56:20PM CET:
> * Stefano Lattarini wrote on Tue, Jan 18, 2011 at 11:57:24PM CET:
> > On Tuesday 18 January 2011, Ralf Wildenhues wrote:
> > > This patch fixes all but 9 of the 76 or so instspc*.test failures on
> > > Tru64.  It is for the tests-init branch, or a tests-init-fixes on top of
> > > v1.11-395-ge118126 I guess.  I'll wait a couple of days before pushing.
> > >
> > The patch is ok with me (but see below).  BTW, the idea of having an
> > 'errexit' clean `tests/defs' sounds good to me, indipendently from the
> > issue at hand.  But I won't go as far as asking for a separate patch ;-)

Ahh, but it would have needed to be in that very patch, unfortunately.
As it is, my last patch fixed Tru64, but regressed NetBSD by roughly the
same number of failures, because `unset NOT_SET' fails there.

Luckily the `set +e/set -e' commands weren't actually required for
Tru64 sh to work (they just didn't help either, that was all), so
unless you complain I'll reinstate that part of the code again.

For tests-init -> master.


    tests: revert not turning off errexit in
    * tests/ Turn off errexit while sourcing defs,
    the scripts might still not be clean.

diff --git a/tests/ b/tests/
index 78f40c4..38a63a4 100755
--- a/tests/
+++ b/tests/
@@ -191,8 +191,12 @@ fi
 ###  If we are still here, we have to run a test ...
-# We'll need the full setup provided by `tests/defs'.
+# We'll need the full setup provided by `tests/defs'.  Temporarly disable
+# the errexit flag, since the setup code might not be prepared to deal
+# with it.
+set +e
 . ./defs || Exit 99
+set -e
 eval "instspc_test_string=\${instspc__$instspc_test_name}" || Exit 99
 if test x"$instspc_test_string" = x; then

reply via email to

[Prev in Thread] Current Thread [Next in Thread]