[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {yacc-work} tests: cover yacc target-specific flags, and `-v

From: Ralf Wildenhues
Subject: Re: [PATCH] {yacc-work} tests: cover yacc target-specific flags, and `-v' flag handling
Date: Fri, 21 Jan 2011 19:40:36 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Fri, Jan 21, 2011 at 01:13:35PM CET:
> A small testsuite patch which slightly increases coverage of
> Automake Yacc support.  OK for the temporary branch yacc-work
> (which at this point could as well be made public maybe), to
> be merged into master?
> I will push in 72 hours if there are no objections.

The patch is OK, but still, can you please wait until, say, at least
Monday before pushing?  I'm hopeful that I can finish one pass over
testsuite failures this weekend, and would like to have a "good" rerun
then that we can use as base for comparison, without introducing more
than necessary drift in the meantime.

The point of introducing new tests is lessened if we don't sometimes go
around and fix the issues that running them exposes.  And we really
should strive to have zero FAILures in the test suites by the next
release on all but the near-museum systems.  Things that we cannot fix
should be XFAILs instead; distros typically won't upgrade upon test
failures, so abusing that as TODO list is not a good idea in the longer
term (not even short-term, as having failures for a longer time tends to
blind oneself for new regressions).


> tests: cover yacc target-specific flags, and `-v' flag handling
> * tests/yacc-basic: Try also to build a parser having `-v' as

Also try

> target-specific flags.  Add a couple of `ls -l' commands, for
> debugging.  Update and extend comments.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]