[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {yacc-work} tests: more coverage on yacc/lex silent-rules, p

From: Stefano Lattarini
Subject: Re: [PATCH] {yacc-work} tests: more coverage on yacc/lex silent-rules, plus minor cleanups
Date: Sat, 22 Jan 2011 18:38:29 +0100
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

Hi Ralf.

I've (basically) addressed all your nits, and pushed to yacc-work.

Just one nit on my part ...

> > +# Check that the expected non-generic rules has been truly generated.
> truly have been generated.
> > +# Otherwise, the coverage offered by this test will be weaker then
> > +# expected and planned.
> s/and planned// ?
Hadn't we agreed to use a short sentence here?  You suggested:
  # Ensure per-target rules are used, to ensure their coverage below.
and I went with that.

> > +$FGREP 'bar-parse.c'
> > +$FGREP '$(bar_YFLAGS)'
> [...]


reply via email to

[Prev in Thread] Current Thread [Next in Thread]