automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {yacc-work} tests: more coverage on yacc/lex silent-rules, p


From: Ralf Wildenhues
Subject: Re: [PATCH] {yacc-work} tests: more coverage on yacc/lex silent-rules, plus minor cleanups
Date: Sat, 22 Jan 2011 18:53:27 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Sat, Jan 22, 2011 at 06:38:29PM CET:
> I've (basically) addressed all your nits, and pushed to yacc-work.

Thanks!

> Just one nit on my part ...
> 
> > > +# Check that the expected non-generic rules has been truly generated.
> > 
> > truly have been generated.
> > 
> > > +# Otherwise, the coverage offered by this test will be weaker then
> > > +# expected and planned.
> > 
> > s/and planned// ?
> > 
> Hadn't we agreed to use a short sentence here?  You suggested:
>   # Ensure per-target rules are used, to ensure their coverage below.
> and I went with that.

Ah, ok, sorry about that.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]