[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests defs: sanitize IFS

From: Ralf Wildenhues
Subject: Re: [PATCH] tests defs: sanitize IFS
Date: Sun, 23 Jan 2011 13:08:03 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Sun, Jan 23, 2011 at 12:56:45PM CET:
> Done in the attached patch.  OK for maint?


Comments explaining the unobvious bits of why something is done are much
more helpful than comments explaining the obvious: what is done can be
seen by reading the code.  Please cf. the respective bits in
gnulib/tests/ shorter but actually more informative:

  # As autoconf-generated configure scripts do, ensure that IFS
  # is defined initially, so that saving and restoring $IFS works.
  IFS=" ""      $gl_init_sh_nl_"


> Subject: [PATCH] tests defs: sanitize IFS
> * tests/ ($IFS): Define to <space>, <tab>, <newline>.
> ($sp): New variable, holding a single whitespace character.
> ($tab): New variable, holding a tabulation character.
> ($nl): New variable, holding a newline character.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]