[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] {master} cosmetics: better use of m4 quoting and m4sugar mac
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] {master} cosmetics: better use of m4 quoting and m4sugar macros |
Date: |
Thu, 17 Mar 2011 23:25:41 +0100 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
On Thursday 17 March 2011, Ralf Wildenhues wrote:
> Hi Stefano,
>
> * Stefano Lattarini wrote on Thu, Mar 17, 2011 at 12:21:15PM CET:
> > <http://lists.gnu.org/archive/html/automake-patches/2011-02/msg00005.html>
>
> > Now patch ready! (about time you'll say :-)
> > The testsuite still passes with it applied.
> >
> > OK for master? I'll push in 72 hours if there's no objection.
>
> The changes are fine, but ...
>
> > Subject: [PATCH] cosmetics: better use of m4 quoting and m4sugar macros
> >
> > * m4/dmalloc.m4: Better use of m4 quoting. Bump serial number.
> > * m4/gcj.m4: Likewise.
> > * m4/init.m4: Likewise.
> > * m4/install-sh.m4: Likewise.
> > * m4/lex.m4: Likewise.
> > * m4/multi.m4: Likewise.
> > * m4/option.m4: Likewise.
> > * m4/python.m4: Likewise.
> > * m4/sanity.m4: Likewise.
> > * m4/cond.m4: Likewise. Also, prefer the m4sugar macro 'm4_if'
> > over the plain m4 macro 'ifelse'.
> > * m4/depend.m4: Likewise.
>
> > * tests/deprecated-acinit.test: New test.
> > * tests/Makefile.am (TESTS): Update.
>
> I'd put this part in a separate commit, as it is not tightly related.
>
OK. Done and pushed (after fixing the botched copyright years in the
new tests).
Thanks,
Stefano