automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[FYI] {testsuite-work} tests: fix spurious failure in backcompat2.test o


From: Stefano Lattarini
Subject: [FYI] {testsuite-work} tests: fix spurious failure in backcompat2.test on NetBSD
Date: Thu, 2 Jun 2011 14:42:41 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

* tests/backcompat2.test: Add trailing `:' in the body of a `for'
loop, in case the last command there might have an exit status
different 0.  This work around `set -e' issues in some BSD shells,
e.g., NetBSD /bin/ksh.
---
 ChangeLog              |    8 ++++++++
 tests/backcompat2.test |    5 +++++
 2 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 52d81f7..9ec9083 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
 2011-06-02  Stefano Lattarini  <address@hidden>
 
+       tests: fix spurious failure in backcompat2.test on NetBSD
+       * tests/backcompat2.test: Add trailing `:' in the body of a `for'
+       loop, in case the last command there might have an exit status
+       different 0.  This work around `set -e' issues in some BSD shells,
+       e.g., NetBSD /bin/ksh.
+
+2011-06-02  Stefano Lattarini  <address@hidden>
+
        tests: fix spurious failure in autohdr3.test
        * tests/autohder3.test (Makefile.am): Let `test' depend on `all',
        so that config.h header is truly remade.
diff --git a/tests/backcompat2.test b/tests/backcompat2.test
index 98336ea..5be6aec 100755
--- a/tests/backcompat2.test
+++ b/tests/backcompat2.test
@@ -45,6 +45,11 @@ END
   # The non-empty third argument should prevent PACKAGE and VERSION
   # from being AC_DEFINE'd.
   $EGREP 'pkg(name|version)' config.h && Exit 1
+  # This is required because even relatively-recent versions of the
+  # BSD shell wrongly exit when the `errexit' shell flag is active if
+  # the last command of a compound statement fails, even if it should
+  # be protected by the use of "&&".
+  :
 done
 
 for am_extra_args in '' ',' ', []'; do
-- 
1.7.2.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]