[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Patch reviews (was: Re: [FYI] {testsuite-work} tests: use `$SHELL' to ru

From: Stefano Lattarini
Subject: Patch reviews (was: Re: [FYI] {testsuite-work} tests: use `$SHELL' to run the shell scripts from `lib/')
Date: Sun, 5 Jun 2011 14:56:09 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

On Sunday 05 June 2011, Peter Rosin wrote:
> Den 2011-06-04 11:24 skrev Stefano Lattarini:
> > Yes, and you're absolutely right complaining about the LIB= -> LIB=''
> > useless change, and the cat -> unindent "unreported" change; for them
> > I can only apologize, and fix the ChangeLog entry to report the latter.
> Did you look for more stuff that may have wiggled its way in? What is
> the answer to the million dollar question?
> You need to read through your own patches more carefully. Slow down.
> What's the rush?

> Especially when there is virtually no review process.
> You are also not inviting review when you mostly push FYI patches
> where the review is an afterthought at best.
I was doing so just because Ralf had made clear that, due to personal
reasons, he's unfortunately not avaiable for patch reviews in this
period; and he was basically the only one doing reviews here.
But if you say that you might be interested in chiming in more often,
that's great for me; I will happily restore the 48 or 72 hours grace
time before pushing a patch (outside master and maint, that is; these
two branches should only take bug fixes until Ralf is available again).

> Where will the testsuite-work branch go anyway?
Ideally in master (eventually, once it has been more thoroughly tested
and rewied, and has become more clean and stable).

> If you intend to merge it, it would perhaps make sense to try to keep
> it reasonably clean and leave at least some room for review?
Yes.  See my proposal above.

> And don't make the mistake that my
> random "reviews" somehow means that I have no issues with stuff that
> I'm not commenting on. Assume that *noone* read a patch (other than
> you, hopefully) if there are no comments.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]