Re: [PATCH] tests: few fixlets and improvements

[Stefano Lattarini]

On Monday 13 June 2011, Stefano Lattarini wrote:
> A simple patch with few minor improvements to four random test cases.
> 
> I'll push in 48 hours if there is no objection by then.
> 
> Regards,
>   Stefano
> 
> -*-*-*-
> 
> tests: few fixlets and improvements
> 
> * tests/cond31.test ($required): Remove `cc', it's not really
> needed.
> * tests/confh.test: Call autoheader too.  The lack of this call
> wasn't causing spurious failures because the automatic remake
> rules were somehow invoking it on our behalf.
> * tests/fn99subdir.test: Use $subdirname throughout, instead of
> ${subdirname}, for consistency with the rest of the testsuite.
> Avoid an unnecessary subshell, which could also cause spurious
> passes, being guarded by a trailing `|| Exit 1', which neutralize
> the `errexit' flag.  Remove an unnecessary `|| Exit 1' guard.
> * tests/insh2.test: Rewrite to avoid hackish Makefile.in munging,
> and to also run configure and make.
> ---
>  ChangeLog             |   16 ++++++++++++++++
>  tests/cond31.test     |    1 -
>  tests/confh.test      |    1 +
>  tests/fn99subdir.test |   36 +++++++++++++++++++-----------------
>  tests/insh2.test      |   15 +++++++++++----
>  5 files changed, 47 insertions(+), 22 deletions(-)
> 
I've pushed the patch now (to 'testsuite-works').

Regards,
  Stefano