automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [FYI] {maint} tests: report useful system information from 'test-sui


From: Eric Blake
Subject: Re: [FYI] {maint} tests: report useful system information from 'test-suite.log'
Date: Thu, 22 Dec 2011 07:41:41 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

On 12/22/2011 07:30 AM, Stefano Lattarini wrote:
> * tests/get-sysconf.test: New test, gathering system information
> and then always terminating with a SKIP, so that its output gets
> copied in `test-suite.log'.
> * tests/Makefile.am (TESTS): Add it.

I like the idea.  But I'm afraid it might introduce a few bug reports on
its own ("I ran the testsuite, and it skipped 1 test - how do I fix
things to not skip that test?").

I also worry that since config.log can be long, it might make the user's
email long enough to trip up list posting limitations, and not all users
know how to compress things to get around that.  And even if they do
compress it, it's that much harder to read the testsuite failure report.

But I don't have any ideas for how to do better, so you might as well go
with it.

> +# Dummy test case, aimed at reporting useful system information in the
> +# final `test-suite.log'.  This way, if a user experiencing a failure in
> +# the Automake test suite only sends us the `test-suite.log' file upon,
> +# we won't have to ask him for more information to start analyzing the
> +# failure (that had happened too many times in the past!).

grammar:

This way, if a user experiences a failure in the Automake test suite,
then only sends us the `test-suite.log', we won't have to...

> +
> +if test $st -eq 0; then
> +  # This test SKIPs, so that all the information is has gathered and

s/is has //

> +  # printed will get unconditionally copied into the `test-suite.log'
> +  # file.
> +  Exit 77
> +fi
> +
> +# Some unexpected error occurred; this must be reported as an hard error
> +# by the testsuite driver.
> +Exit 99

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]