automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {maint} dist: add support for lzip compression


From: Eric Blake
Subject: Re: [PATCH] {maint} dist: add support for lzip compression
Date: Fri, 30 Dec 2011 07:05:03 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0

On 12/30/2011 06:47 AM, Stefano Lattarini wrote:
> 
> OK, I've applied the patch with a couple of very minor tweaks.  Attached is
> what I'll push in your name once I've leant what is the kosher/blessed way
> to mark a git commit with a "no paperwork required" attribute.

Alas, right now the "solution" was a gnulib-local patch to each project,
as we did not yet feel comfortable including it upstream in gnulib:

https://lists.gnu.org/archive/html/bug-gnulib/2011-11/msg00234.html

> 
> * NEWS: Update.
> * automake.in (handle_dist): Recognize dist-lzip.
> (make_paragraphs): Map LZIP to dist-lzip.
> * doc/automake.texi (Dist, Options): Describe dist-lzip.
> * lib/Automake/Options.pm (_process_option_list): Recognize
> `dist-lzip'.
> * lib/am/distdir.am (dist-lzip): New target.
> (DIST_ARCHIVES) [?LZIP?]: Add `dist-lzip'.
> (dist, dist-all) [?LZIP?]: Add command to create an lzip-compressed
> tarball.
> (distcheck): Handle lzip-compressed tarballs just like the others.
> * tests/lzip.test: New test.
> * tests/Makefile.am (TESTS): Add it.
> ---
>  NEWS                    |    2 ++
>  automake.in             |    3 ++-
>  doc/automake.texi       |   16 ++++++++++++++--
>  lib/Automake/Options.pm |    2 +-
>  lib/am/distdir.am       |    9 +++++++++
>  tests/Makefile.am       |    1 +
>  tests/lzip.test         |   43 +++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 72 insertions(+), 4 deletions(-)

That's an awfully big diffstat to be attributing to Antonio under the
no-assignment rules.  Would it be better to split this into two commits
- Antonio's actual (tiny) change, and separately the tests/ addition
that you wrote to expose it?

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]