[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [FYI] {master} depcomp tests: put TAP plan in generated tests

From: Stefano Lattarini
Subject: Re: [FYI] {master} depcomp tests: put TAP plan in generated tests
Date: Thu, 16 Feb 2012 20:51:25 +0100

Hi Peter, thanks for catching this.

On 02/16/2012 07:59 PM, Peter Rosin wrote:
> Stefano Lattarini skrev 2012-02-16 19:38:
>> -      plan_ 84
> *snip*
>> +        my $planned = ($lt && $m eq "auto") ? 72 : 28;
> 84?
Yes, it should be so...  But then again, I had run all the 'depcomp*.tap'
tests before pushing, and encountered no failure...  Nor am I encountering
it now, even if depcomp-lt-auto.tap is running just 28 tests!

... And that's because the generated tests call the 'plan_' function
before it is defined!  Ouch.  The attached patch should fix the issue.

Sorry for the noise,

Attachment: 0001-depcomp-tests-fix-up-today-s-botched-commit.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]