[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHES] Fix issues with $(am__dry_run) and metacharacters in $(MAK

From: Peter Rosin
Subject: Re: [PATCHES] Fix issues with $(am__dry_run) and metacharacters in $(MAKEFLAGS)
Date: Fri, 17 Feb 2012 12:54:59 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.1) Gecko/20120208 Thunderbird/10.0.1

Stefano Lattarini skrev 2012-02-17 12:00:
> Two patches: a fix to be applied to maint, and a testsuite enhancement to
> be applied to master.
> Tested with GNU make from 3.79 to 3.82, FreeBSD 9.0 make, OpenBSD 5.0 make,
> NetBSD 5.1 make, Solaris 10 CCS make and Sun Distributed Make 7.8.
> I will push soonish if there is no objection.

Some simple typo fixes follow inline in the below heavily snipped quote, I
haven't looked at the change as such though...


> diff --git a/tests/make-dryrun.tap b/tests/make-dryrun.tap

> +# Test against a known regressions.  This was especially

s/regressions/regression/ (I know, not from this patch, but perhaps since you
are at it)

> +# heinous, since make running in normal mode was sometimes
> +# mistaken for make running in dry mode.

> Subject: [PATCH] dryrun: $(am__dry_run) not confused by metachars in
> * lib/am/ (am__make_dryrun): Make smarter and more
> correct in handling shell metacharacters in $(MAKEFLAGS).

s/Make/Be/ and perhaps
s/in handling/in handling of/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]